Add apt::keyring defined type #1120
Conversation
|
|
| # Ensure presence or absence of the resource. | ||
| # | ||
| define apt::keyring ( | ||
| Stdlib::Absolutepath $keyring_dir = '/etc/apt/keyrings', |
There was a problem hiding this comment.
This is already defined as apt::params::trusted_gpg_d
There was a problem hiding this comment.
True, but for new-style APT keyrings, /etc/apt/keyrings is the preferred location.
Changing it only here means the new-style keyrings can be deployed to /etc/apt/keyrings by default, without affecting the rest of the module.
| Enum['present','absent'] $ensure = 'present', | ||
| ) { | ||
| ensure_resource('file', $keyring_dir, { ensure => 'directory', mode => '0755', }) | ||
| if $source and $content { |
There was a problem hiding this comment.
We probably want a similar check when none of source and content is set. The provided unit test in this regard is incomplete because I would expect such code to fail.
There was a problem hiding this comment.
Good idea. I have added another condition which will catch this scenario.
Applying suggestions from code review Co-authored-by: Romain Tartière <romain@blogreen.org>
|
Should be closed, was done in #1128. |
|
Thanks @kenyon! |
Summary
Add a new defined type for adding GPG keyrings.
Additional Context
apt-key is deprecated in the latest Debian and Ubuntu releases. Therefore we should move away from the old
apt::keydefined type which relies on it.With this we can manage apt keyrings directly with the apt module. Further work would be required to integrate this directly into the
apt::sourcelike howapt::keyis currently.Reference - https://wiki.debian.org/DebianRepository/UseThirdParty
Related Issues (if any)
#1034
Checklist
puppet apply)